[DISCUSS] Fork or cleanup this package? Nominate PRs proven useful to you for merging

[fungilation]

Issues and PRs are largely unattended for months now, and the owner just updates README with recruitment ads. My app's main navigation is built around this library so I have a vested interest in improving and maintaining this, with community contribution and merging useful PRs on queue here. My own fork is working well up to current RN 0.57.0 on both iOS and Android.

If we move to a new repo under a new name, what name should it be? What PRs should be merged?

My idea for new name: react-native-snap-scrollview or react-native-snap-swiper

Discuss.

[afilp]

I prefer react-native-snap-swiper, only because it is shorter and has swiper included.

[kristerkari]

I think that if this is getting forked into something that is maintained, it would be a good idea to divide the issues to a list of bugs and a list of features, and then create a proposed roadmap for the features/fixes that would be done next.

I think that I could help out, at least for a while, to get that done.

[arribbar]

Sorry guys. I haven't been present in the past few months. I am ready to help maintain this project with you if you want to. :)

A roadmap is a good idea indeed.
I think it would be a good idea to start from a fresh repo. Let all PRs and issues author know there is a fresh repo.

Sorry again for not helping out in the past

[fungilation]

Fragmentation is not good for OSS, so working together is for the best. Whether in this repo or new.

@arribbar, is new repo actually better? Do you have npm access for this package?

[pascaloliv]

I agree with @fungilation - fragmentation is bad. What is @leecade 's point of view on this situation ?

[arribbar]

I have access to npm package and I can add any maintainer. I just need your npm username.
If we keep this repo, we'll need to clean all issues and PRs and it will takes some time to do so.
But if we change it, all users will need to change for the new one...

It might be better to keep going with this project. We just need to have admin rights on github project.

[pascaloliv]

Maybe the time has come for a fresh new 2.0.0 👍

[arribbar]

I can make a new release if you want to this week or the next one
Just tell me which PRs need to be merged in the new release and I'll do it

[kristerkari]

I definitely agree, there is no need for a fork if we can just clean the current situation by properly maintaining the project.

Maybe the time has come for a fresh new 2.0.0 👍

If you mean the version of the library and if we look at the situation strictly from a semantic version point of view, then the major version bumps should not reflect the state of the project, but rather the state of the library/code. Of course if there are a lot of new features, then it might even make sense to do a major version bump.

I can make a new release if you want to this week or the next one
Just tell me which PRs need to be merged in the new release and I'll do it

I would suggest to start labeling issues and pull requests and creating a some kind of milestone, like "next release" which would include the features that are planned for the next release. That way it would be A LOT easier to handle the current situation where you just have a bunch of issues and pull requests.

[pascaloliv]

@kristerkari : I said 2.0.0 because I anticipated some major changes yeah. But I'm not sure about how big the diff is between the leecade/react-native-swiper and @fungilation fork.

+1 : Good idea to flag some important issues / merge requests / features for the next milestone and release.

[arribbar]

I agree with you @kristerkari
We'll just need to do some cleaning in issues and PRs but that's ok

I have just created next release tag for now

I'll let you decide which PRs need to be merged. I'll do a check next week
If you have other ideas, feel free to share them :)

[fungilation]

Title changed. Let's nominate PRs that's already been tested to work, in your own app or test repo. For merging for next release.

I nominate #789 #684

@arribbar, thanks for continuing to help maintaining this package. You said "We just need to have admin rights on github project." Does that mean you don't have all github permissions and if so, what are you missing that'd warrant forking to a new repo?

[arribbar]

Well, I cannot add/remove any maintainers. It would be better if some users can have these rights.
I asked @leecade if I could have them. Let's see ...

[fungilation]

Ya let's see. If you get full admin access then no reason for us to rename the package.

[arribbar]

Release 1.5.14 just done with #789 #684 merged

[arribbar]

Another question for you guys,
I am a bit lost between index.d.ts, a typescript file, and index.js.flow, a flow file. Should we keep both files ? How can we update/test these files ?

Another one which would be great, I'd like to add a how to contribute file. Do you have some ideas about what to put in this file ? And some time to write it ? :)

And what do we do about all these PRs and issues ?

[fungilation]

On PRs, I was asking people to nominate PRs they actually use or want.

[sfratini]

I siwtched to this one: https://github.com/archriss/react-native-snap-carousel

Seems to have more traffic, features and less issues.