Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dependency string with voca #9

Open
nicojs opened this issue Aug 1, 2018 · 1 comment
Open

Replace dependency string with voca #9

nicojs opened this issue Aug 1, 2018 · 1 comment

Comments

@nicojs
Copy link

nicojs commented Aug 1, 2018

Installing this package results in a security audit warning (high):

$ npm audit

                       === npm audit security report ===
                                 Manual Review
             Some vulnerabilities require your attention to resolve
          Visit https://go.npm.me/audit-guide for additional guidance

  High            Regular Expression Denial of Service
  Package         string
  Patched in      No patch available
  Dependency of   markdown-it-named-headers [dev]
  Path            markdown-it-named-headers > string
  More info       https://nodesecurity.io/advisories/536
found 1 high severity vulnerability in 693 scanned packages
  1 vulnerability requires manual review. See the full report for details.

After some digging, it seems that this issue is reported to string.js, but the project seems all but abandoned: jprichardson/string.js#212 (comment)

It is only used for slugify here:

var slug = string(s).slugify().toString();

Could we replace this with voca? That package doesn't have a security warning.

@nicojs nicojs changed the title Replace string.js with voca Replace dependency string with voca Aug 1, 2018
@jimmywarting
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants