Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use without CreateRole/GetRole permission #13

Open
etgrieco opened this issue Jun 6, 2018 · 1 comment
Open

Cannot use without CreateRole/GetRole permission #13

etgrieco opened this issue Jun 6, 2018 · 1 comment
Assignees
Milestone

Comments

@etgrieco
Copy link

etgrieco commented Jun 6, 2018

I think this plugin is very useful for manipulating stage variables. However, I don't want my ability to easily handle stage variabels in serverless.yml to come at the expense of adding unnecessary permissions to my AWS deployment user.

In my institution's case, we would only like to be able to control the API caching variables and don't need to touch any of the CloudWatch functionality. So giving our deployment user CreateRole/GetRole is too broad.

I am considering creating a PR where either 1) the functionality can be manually turned off through the stageSettings or 2) the cloudwatch permissions are only required if certain MethodSettings that rely on it are manipulated.

Happy to contribute. Currently leaning towards the second implementation as this means less configuration for the end-user.

Wondering your thoughts if you're continuing to maintain this plugin.

@leftclickben
Copy link
Owner

FYI @etgrieco https://github.com/leftclickben/serverless-api-stage/pull/17/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants