Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set module status #586

Merged
merged 2 commits into from
Sep 2, 2023
Merged

fix: set module status #586

merged 2 commits into from
Sep 2, 2023

Conversation

leg100
Copy link
Owner

@leg100 leg100 commented Sep 2, 2023 •
edited
Loading

The module status was being set to 'pending' and then never updated.

  • set non-pending statuses
  • (ui): ensure module page still renders when setup fails or no tags are found

@leg100 leg100 changed the title fix(ui): handle other module status gracefully fix(ui): handle other module statuses gracefully Sep 2, 2023
@leg100 leg100 changed the title fix(ui): handle other module statuses gracefully fix: set module status Sep 2, 2023
@leg100 leg100 merged commit 8141c6e into master Sep 2, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Sep 2, 2023
Merged
leg100 pushed a commit that referenced this pull request Sep 6, 2023
@github-actions
chore(master): release 0.1.10 (#587)
fc64a73 
🤖 I have created a release *beep* *boop*
---


## [0.1.10](v0.1.9...v0.1.10)
(2023-09-06)


### Bug Fixes

* **integration:** ensure text box is visible before focusing
([8d279ae](8d279ae))
* set module status ([#586](#586))
([8141c6e](8141c6e))
* **ui:** remove undefined css classes
([daf6096](daf6096))
* **ui:** wrong heading for edit variable set variable page
([cc6f282](cc6f282))
* variable set variables API
([#589](#589))
([8e29da1](8e29da1)),
closes [#588](#588)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@leg100 leg100 deleted the fix-broken-module-page branch December 16, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leg100