fix: retrieving state outputs only requires read role #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,6 @@ func (a *authorizer) CanAccess(ctx context.Context, action rbac.Action, workspac | |||
| if subj.CanAccessWorkspace(action, policy) { | |||
| return subj, nil | |||
| } | |||
| a.Error(nil, "unauthorized action", "workspace_id", workspaceID, "organization", policy.Organization, "action", action, "subject", subj) | |||
| a.Error(nil, "unauthorized action", "workspace_id", workspaceID, "organization", policy.Organization, "action", action.String(), "subject", subj) | |||
There was a problem hiding this comment.
Thank you, action = 80 wasn't very informative.
|
Yes, another regression alas. Moved from zerolog to slog recently for
logging, and the latter doesn't appear to check if inputs implement
Stringer.
…On Wed, Sep 13, 2023, 7:31 PM François Saint-Jacques < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In internal/workspace/authorizer.go
<#603 (comment)>:
> @@ -27,6 +27,6 @@ func (a *authorizer) CanAccess(ctx context.Context, action rbac.Action, workspac
if subj.CanAccessWorkspace(action, policy) {
return subj, nil
}
- a.Error(nil, "unauthorized action", "workspace_id", workspaceID, "organization", policy.Organization, "action", action, "subject", subj)
+ a.Error(nil, "unauthorized action", "workspace_id", workspaceID, "organization", policy.Organization, "action", action.String(), "subject", subj)
Thank you, action = 80 wasn't very informative.
—
Reply to this email directly, view it on GitHub
<#603 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASPUBDQ63T5YIQZZW2H63X2H3WJANCNFSM6AAAAAA4WZ7ELA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
leg100
pushed a commit
that referenced
this pull request
Sep 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.1.13](v0.1.12...v0.1.13) (2023-09-13) ### Features * add flags --oidc-username-claim and --oidc-scopes ([#605](#605)) ([87324d0](87324d0)), closes [#596](#596) ### Bug Fixes * restart spooler when broker terminates subscription ([#600](#600)) ([ce41580](ce41580)) * retrieving state outputs only requires read role ([#603](#603)) ([25c4a99](25c4a99)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #601.
Retrieving the current state outputs should not require organization ownership, only a read role on the workspace or a workspace admin role. This PR addresses that.
Also refactors the output retrieval code: instead of retrieving each output one by one, all outputs are retrieved at once.