adjust energy calibration to uncertainties in literature values #102
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #102 +/- ##
=======================================
Coverage 21.33% 21.33%
=======================================
Files 36 36
Lines 3305 3305
=======================================
Hits 705 705
Misses 2600 2600 ☔ View full report in Codecov by Sentry. |
fhagemann
approved these changes
Dec 12, 2024
fhagemann
added a commit
that referenced
this pull request
Dec 12, 2024
adjust energy calibration to uncertainties in literature values
|
I pushed these changes onto |
fhagemann
added a commit
to fhagemann/LegendSpecFits.jl
that referenced
this pull request
Dec 12, 2024
adjust energy calibration to uncertainties in literature values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change:
th228_lineswill have uncertainty values after the upcoming change in legend-metadata.I changed the simple calibration so that it can handle these uncertainties. The other functions involved in the energy calibration worked as is.