Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#443] Modified Airflow worker permissions to enable ConfigMap creation #444

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

float34
Copy link
Contributor

@float34 float34 commented Sep 10, 2018

Added appropriate permissions to Airflow worker so it will be able to create and save ConfigMaps.
This PR closes #443

kirillmakhonin
kirillmakhonin previously approved these changes Sep 10, 2018
aliaksandr-d
aliaksandr-d previously approved these changes Sep 10, 2018
@aliaksandr-d aliaksandr-d added the improvement [Changed] for changes in existing functionality label Sep 10, 2018
@aliaksandr-d
Copy link
Member

Ok to test

@legion-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@kirillmakhonin
Copy link
Member

ASK [aws_resources : Create Airflow Postgres RDS instance] ********************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Timeout waiting for RDS resource legion-ci-airflow-rds"}
	to retry, use: --limit @/var/lib/jenkins/workspace/Create_cluster/deploy/ansible/create-cluster.retry

@kirillmakhonin
Copy link
Member

ok to test

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@aliaksandr-d
Copy link
Member

Downloading plugin: favorite-plugin from https://updates.jenkins.io/download/plugins/favorite-plugin/2.3.2/favorite-plugin.hpi

Failed to download plugin: favorite or favorite-plugin

@kirillmakhonin
Copy link
Member

ok to test

@kirillmakhonin
Copy link
Member

@aliaksandr-d @Torquerrr please check that with this RBAC rule configmaps from other namespaces are not accessable.

@kirillmakhonin
Copy link
Member

@aliaksandr-d and please modify RBAC rule to allow operations only with required configmaps

@aliaksandr-d
Copy link
Member

Need to rework role mapping. Please, add regular expression for a configmap and secrets names, check if other configmaps and secrets are unavailable, also please check the restrictions for configmaps in other namespaces.

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@aliaksandr-d
Copy link
Member

@kirillmakhonin
Looks like it's forbidden to use asterisk in resourceNames field in K8s Role.
Also rule in K8s Role doesn't support any labels selectors. We should specify an exact list of configmaps or secrets.
kubernetes/kubernetes#56582 (comment)
If you have another solution, please, let me know.

@aliaksandr-d
Copy link
Member

ok to test

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@aliaksandr-d aliaksandr-d dismissed stale reviews from kirillmakhonin and themself via 5033e0c September 13, 2018 08:26
@aliaksandr-d aliaksandr-d force-pushed the feat/443-airflow-worker-permissions branch from 7914389 to 5033e0c Compare September 13, 2018 08:26
@aliaksandr-d
Copy link
Member

ok to test

@legion-bot
Copy link
Collaborator

Build status: FAILURE

1 similar comment
@legion-bot
Copy link
Collaborator

Build status: FAILURE

Copy link
Member

@akharlamov akharlamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kirillmakhonin
Copy link
Member

ok to test

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@aliaksandr-d
Copy link
Member


TASK [legion_enclave : Attach Airflow S3 accesse policy to the role] ***********
fatal: [localhost]: FAILED! => {"changed": true, "msg": "Rate exceeded"}
	to retry, use: --limit @/var/lib/jenkins/workspace/Deploy_Legion_Enclave/deploy/ansible/deploy-legion-enclave.retry

@aliaksandr-d
Copy link
Member

ok to test

@legion-bot
Copy link
Collaborator

Build status: FAILURE

@aliaksandr-d
Copy link
Member

Check EDI scale up procedure :: Try to scale up model through EDI ... 
2018-09-19 08:30:03,109 - INFO - Some hanging processes have been detected for failed test 'Check EDI scale up procedure'

2018-09-19 08:30:03,109 - INFO - Killing active process 'legionctl --verbose scale demo-abc-model 2 --edi https://edi-company-a.legion-ci.epm.kharlamov.biz --user admin --password admin' for test 'Check EDI scale up procedure' because of 'Test timeout 6 minutes exceeded.'

2018-09-19 08:30:03,109 - DEBUG - Killing process #10362

2018-09-19 08:30:13,110 - ERROR - Cannot gather process #10362 logs: ExecutionTimeoutException()
/var/lib/jenkins/workspace/Deploy_Legion_Release/.venv/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py:791: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
  InsecureRequestWarning)
/var/lib/jenkins/workspace/Deploy_Legion_Release/.venv/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py:791: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
  InsecureRequestWarning)
[ ERROR ] Cannot gather process #10362 logs: ExecutionTimeoutException()
| FAIL |
Test timeout 6 minutes exceeded.

@aliaksandr-d
Copy link
Member

ok to test

@legion-bot
Copy link
Collaborator

Build status: SUCCESS

@aliaksandr-d aliaksandr-d merged commit d3f2cda into develop Sep 20, 2018
@kirillmakhonin kirillmakhonin deleted the feat/443-airflow-worker-permissions branch September 28, 2018 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement [Changed] for changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airflow worker unable to create ConfigMap
5 participants