CMSAction - Removes Gridfield details on saving

[mspacemedia]

This might be my implementation, but when I click an item in a gridfield and then the resultant CMSAction on that object the module removes the Gridfield status from the URL, this then means clicking next/prev or save and next do not work as normal.

->setShouldRefresh to true or false makes no difference either.

My code is in updateCMSActions on an extension:

$getLogo = CustomAction::create('doGetLogo', 'Get Logo');
$getLogo->setShouldRefresh(false);
$actions->push($getLogo);

[lekoala]

It might depend on what your action does ? I'm not an expert on gridfield state so maybe it's a matter of checking when the URL is updated incorrectly. I don't see how an Ajax request to an action should change anything

[mspacemedia]

Me either @lekoala, all the action does it guzzle a logo from a URL and save a local copy. It then writes the dataobject to the database to store the ID of the newly 'minted' image in the Filesystem. I then tried with setShouldRefresh set to true and false and both have the same effect on the URL it strips out the GridField URL data…

I shall dig a bit deeper in XDebug

[mspacemedia]

https://github.com/isobar-nz/silverstripe-persistentgridfield appears to fix the issue - to a degree…

[lekoala]

@mspacemedia actually just tried to test this, and i never have gridfield status in the url so prev/next (even the built in nav from silverstripe) always apply to the unfiltered list.
which version of silverstripe are you using?
this seems actually an issue for a while and not really specific to this module i believe
silverstripe/silverstripe-framework#3229

[mspacemedia]

@lekoala I'm seeing this issue in the latest SS4 build from this in composer:

    "silverstripe/recipe-plugin": "^1.2",
    "silverstripe/recipe-cms": "~4.9.0@stable"

[lekoala]

I'm keeping this open but I don't plan to work on it until I have a reproduceable example. If anyone has the issue or finds a solution, a PR is welcome

[silverstripesk]

From SilverStripe 4.12 gridfield state is present in URL. Saving DataObject removes gridState from URL. Default SilverStripe implementation does not remove this from URL. Also Prev/Next buttons do not respect filter applied on gridfield (is present in URL on selected DataObject).

[lekoala]

@silverstripesk wow not sure how i missed that :)
fix is in progress, this is what i've made so far which work for save and close, save and prev/next
bfe61f9

[lekoala]

@silverstripesk @mspacemedia i've made quite a few grid state related updates on master, if you can give it a try and let me know how it goes ? ;-)
it might not be 100% perfect, but i do see a lot of improvements on my test project

[silverstripesk]

works on Prev/Next/Save+Close
doesn't work on Save+Prev/Save+Next

[lekoala]

@silverstripesk that's very odd, it seems to be working just fine for me (tested in modeladmin, on base grid and nested grids)
i've released a new version https://github.com/lekoala/silverstripe-cms-actions/releases/tag/1.3.13 can you make sure to test with it ?

[silverstripesk]

great, now work all buttons.

One visual issue: prev/next buttons are missing arrows

[lekoala]

indeed, missed that one ;-)
i'm closing the issue, the css is fixed here
https://github.com/lekoala/silverstripe-cms-actions/releases/tag/1.3.14