-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.4 stable #276
0.4 stable #276
Conversation
…ix Android 6 issue on some devices
Thanks for finding the issue and fixing it! I think the example app will need to be updated too. |
@locly Nice! Yea, could you update the example to pass |
Yes - have updated the example to declare the package with |
@locly looks good! thanks for the PR merging |
@locly just realized this was for the 0.4-stable branch. I think this should also work for master, any reason not too? |
Fix for#165 and #271 - Android 6.0 crashing on devices such as Xperia Z5 Compact, Z5 Bond and others.
It passes the activity to the package, manager and view so that it can be used in place of the app context when initialising the MapView component.
The new code as also been tested on the following devices to ensure it continues to work as before:
Nexus 4 (Android 5), Nexus 5 (Android 6), Nexus 6P (Android 6)
It requires a change to an app's MainActivity.java to pass
this
when creating the AirPackage:new AirPackage(this)
rather thannew AirPackage()
in the current version.