Support RNW 0.18, remove StyleSheet.resolve API. Refs #147 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mathieudutour @lelandrichardson any chance this can be reviewed and released? |
This was referenced Nov 29, 2022
|
Thanks for submitting this PR. Won’t this break projects that depend on older versions of RNW (pre 0.18) and depend on |
|
It's been a while since I looked at this and I have moved on from trying to fix the emotion bug. I dislike having to close PR's but I won't be able to contribute any further, I apologise. I'll keep the branch around on my fork for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
Fixes #139
This change adds support for RNW 0.18. Refer to #139 for notes on why we should remove the
Stylesheet.resolveAPI.RNW 0.18 has changed its stylesheet implementation to closely match RN.
That RNW change is required to fix a bug in the emotion library (see emotion-js/emotion#1543).
The final piece of the puzzle is to upgrade react-primitives to support RNW 0.18. The react-primitives upgrade is blocking us from fixing that emotion bug.