Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using butler instead of opening the sqlite3 DB? #6

Open
fasterthanlime opened this issue Oct 15, 2019 · 5 comments
Open

Consider using butler instead of opening the sqlite3 DB? #6

fasterthanlime opened this issue Oct 15, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@fasterthanlime
Copy link

fasterthanlime commented Oct 15, 2019

My first worry is that opening the sqlite3 DB from python could corrupt it.

My second worry is that, doing stuff like querying the verdict is not really the recommended way to launch games. I'm releasing a butler upgrade soon that will no longer use that (old verdicts will be cleared out).

The interface at http://docs.itch.ovh/butlerd/master/#/ should be stable, it's already used by Playnite, there's a work-in-progress GameHub integration, etc.

I'm happy to help you get started!

@lele-blue
Copy link
Owner

I'd like to change the integration to using butlerd, however I didn't see an API for getting all installed (or all owned) games, but I might have just missed that?

Also thanks for reaching out and creating the issue :)

@lele-blue lele-blue added the enhancement New feature or request label Oct 15, 2019
@fasterthanlime
Copy link
Author

Hope this helps! There's a few concepts, but I'm happy to assist.

@Informatic
Copy link

Informatic commented Nov 22, 2020

Is anyone working on this? I started some initial work on python butlerd RPC library, and can continue with integrating it into this plugin:
https://gist.github.com/Informatic/66afa809b3b3f1035031c83e529ada9e

@Informatic
Copy link

Turns out integating butlerd into gog galaxy plugin was much faster than I anticipated and managed to get a working POC with owned/installed games listing and game install/uninstall/launch handling working in less than 3 hours.

Putting it out here for reference: https://github.com/Informatic/gog-galaxy-itch.io/tree/butlerd-integration

To properly handle game installation galaxy api package needed to be updated (as the old one was missing supported operating systems reporting), all pinned requirements are dumped in requirements.txt, I'll try to figure out some CI setup to build and release new .zip files with dependencies soon.

Just to make sure - as I don't see any LICENSE note - what is the license for this repo then? If you're not decided yet, I'd suggest just plain old MIT.

@lele-blue
Copy link
Owner

No, I am not aware of anyone working on integrating butler.
As for the license: Seems like I forgot to add one, but yes MIT would be my choice as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants