Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0 of 0 changed or added relevant lines in 0 files are covered. is awkward #1775

Open
jsoref opened this issue Jun 17, 2024 · 1 comment
Open

Comments

@jsoref
Copy link

jsoref commented Jun 17, 2024

thephantomthief/babelfish_extensions#19 (comment)

0 of 0 changed or added relevant lines in 0 files are covered.

I'm having a hard time reading this message. I understand it's because all of the fields are 0s, but that doesn't mean that the message should be hard to read.

The message effectively suffers from division by zero.

The following message would yield as much information to a reader but cause less confusion:

0 changed or added relevant lines in 0 files are covered.

Even that is a bit much. The changed or added relevant lines part is still hard to parse when paired with even the single 0.

It might be possible to simply write:

0 relevant lines in 0 files are covered.

or

0 changed lines in 0 files are covered.

and, beyond that... I'm not sure if 0 files adds value. If there are 0 changed lines, they could come from an infinite number of files and it would still mean the same thing. Thus, I wonder if the message could be simplified to:

0 changed lines are covered.


Note: this is separate from #1743 which asks to fix the case of bad data when processing a PR that crosses forks.

@afinetooth
Copy link
Collaborator

@jsoref Thanks for the report. I have submitted a request to improve the wording in that scenario. I know we have an open ticket to improve copy in PR Comments in general, so it will probably be subsumed by that. No ETA yet, but I'll swing back if I get an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants