Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide API for specifying PR or branch information with coverage reports. #446

Closed
tomprince opened this issue Feb 2, 2015 · 3 comments
Closed

Comments

@tomprince
Copy link

Currently, if one isn't use one of the supported CI providers, there is no way to associate results with a PR. It would be nice if the API allowed me to pass this information to coveralls, if I have access to it.

Ideally, I'd like to specify the commit, the branch it will be merged to, and whether the build is against the result of merging, since we do builds before creating a PR, rather than after. This seems like it should be enough information to report commit status (#25).

@nickmerwin
Copy link
Member

Hi @tomprince actually you can pass this to the API already. See this section of the ruby gem:
https://github.com/lemurheavy/coveralls-ruby/blob/master/lib/coveralls/configuration.rb#L86

What integration library are you using?

@tomprince
Copy link
Author

It doesn't appear to be documented.

Also, it would be nice not to need to know the pull request. We often (usually?) build and test things before opening a PR, so that information isn't available when we submit it.

@nickmerwin
Copy link
Member

Ok I've updated the docs.

Sorry I'm not sure what you mean by not needing to know the PR -- if it wasn't yet associated with one it would build on another branch per usual. Could you clarify?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants