Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem extending paths that are created with no key #36

Open
DougC opened this issue Apr 30, 2019 · 1 comment
Open

Problem extending paths that are created with no key #36

DougC opened this issue Apr 30, 2019 · 1 comment

Comments

@DougC
Copy link
Contributor

DougC commented Apr 30, 2019

This test will fail:

  it should "extend a path with no key correctly" in {
    val path = Path("some-bucket") / "key"

    path must be(Path("some-bucket", "key", None, false, None))
  }

with some-bucket//key was not equal to some-bucket/key

The extension code doesn't check for the empty initial key and you end up with a double '/' in the resulting path.

I'm happy to put together a PR to fix this. Either it can check for a blank key string when extending, or I could change Path.key to be Option[String] to make it more explicit.

@Daenyth
Copy link
Contributor

Daenyth commented Jun 20, 2019

fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants