Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize player's names #34

Open
lenguyenthanh opened this issue Apr 18, 2024 · 0 comments
Open

Sanitize player's names #34

lenguyenthanh opened this issue Apr 18, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lenguyenthanh
Copy link
Owner

Fide has player's name in various forms:

  • Carlsen, Magnus
  • ,alfaifi,Wael ali qasim
  • Amar,, Kahtan

We should sanitize them by removing ,.

Probably just need to add a mapping here:

fide/modules/crawler/src/main/scala/Crawler.scala

Line 71 in 1b4c87d

name <- string(15, 76).map(_.filterNot(_.isDigit).trim)

@lenguyenthanh lenguyenthanh added good first issue Good for newcomers enhancement New feature or request labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lenguyenthanh