Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Content Security Policy for blob #103

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented Sep 1, 2023

Description of the changes

It seems that images are not properly loaded on staging and production because of a missing entry in the Content Security Policy definition. I added the entry following this recommendation : https://stackoverflow.com/a/59485202

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

Technical highlight/advice

Test directly in staging

@jonas-martinez jonas-martinez added the bug Something isn't working label Sep 1, 2023
@jonas-martinez jonas-martinez self-assigned this Sep 1, 2023
@jonas-martinez jonas-martinez merged commit cb50813 into beta Sep 1, 2023
3 checks passed
@jonas-martinez jonas-martinez deleted the add-blob-and-base64-in-csp branch September 1, 2023 13:02
@shiipou
Copy link
Contributor

shiipou commented Sep 1, 2023

🎉 This PR is included in version 1.0.0-beta.42 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Oct 8, 2023

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants