Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Sentry #19

Merged
merged 2 commits into from
Jul 19, 2022
Merged

feat: Add Sentry #19

merged 2 commits into from
Jul 19, 2022

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented Jun 14, 2022 •
edited
Loading

Closes #18

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I included unit tests that cover my changes
  • I added/updated the documentation about my changes
  • I made my own code-review before requesting one

Description of the changes

Technical highlight/advice

@jonas-martinez jonas-martinez added the enhancement New feature or request label Jun 14, 2022
@jonas-martinez jonas-martinez self-assigned this Jun 14, 2022
@Nesqwik Nesqwik self-requested a review July 4, 2022 12:44
pichoemr
pichoemr reviewed Jul 18, 2022
View reviewed changes
Copy link
Contributor

@pichoemr pichoemr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you add the capture of sentry here or in another pr?
If you do it in another PR LGTM

@jonas-martinez
Copy link
Collaborator Author

@pichoemr It will be done in another PR because the errors to catch are located in the lenra-common repository.

@jonas-martinez jonas-martinez merged commit f0d21e9 into beta Jul 19, 2022
@jonas-martinez jonas-martinez deleted the add-sentry branch July 19, 2022 07:43
@shiipou
Copy link
Contributor

shiipou commented Jul 19, 2022

🎉 This PR is included in version 1.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Aug 11, 2023

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Aug 21, 2023

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Oct 8, 2023

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichoemr pichoemr pichoemr approved these changes

@Nesqwik Nesqwik Awaiting requested review from Nesqwik

Assignees

@jonas-martinez jonas-martinez

Labels
enhancement New feature or request released on @alpha released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Sentry
3 participants
@jonas-martinez @shiipou @pichoemr