Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change the old router to the GoRouter to fix some navigation issue. #51

Merged
merged 6 commits into from
Dec 16, 2022
Merged

fix: Change the old router to the GoRouter to fix some navigation issue. #51

merged 6 commits into from
Dec 16, 2022

Conversation

Nesqwik
Copy link
Member

@Nesqwik Nesqwik commented Dec 12, 2022

#50

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I included unit tests that cover my changes
  • I added/updated the documentation about my changes
  • I made my own code-review before requesting one

Description of the changes

i've also changes a few things :

  • The overview/settings route now set the appId in the URL. This allow to copy/past the url and keep the page context.
  • The setting menu is divided into two sub-route. This also keep the page context when copy.

jonas-martinez
jonas-martinez requested changes Dec 13, 2022
View reviewed changes
lib/main.dart Outdated Show resolved Hide resolved
lib/navigation/guard.dart Outdated Show resolved Hide resolved
lib/views/backoffice_top_bar.dart Outdated Show resolved Hide resolved
@jonas-martinez jonas-martinez merged commit 135048e into beta Dec 16, 2022
@jonas-martinez jonas-martinez deleted the nav_fixes branch December 16, 2022 15:32
@jonas-martinez jonas-martinez mentioned this pull request Dec 27, 2022
Closed
@shiipou
Copy link
Contributor

shiipou commented Aug 11, 2023

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Aug 21, 2023

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Oct 8, 2023

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-martinez jonas-martinez jonas-martinez approved these changes

Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nesqwik @shiipou @jonas-martinez