Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add iOS case in platform uri scheme #104

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: Add iOS case in platform uri scheme #104

merged 1 commit into from
Dec 11, 2023

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented Dec 11, 2023

About this PR

Closes #

There was a problem when trying to run the OAuth on a iOS environment. The app would not catch the event from the integrated browser. To fix it, we just need to handle iOS the same as Android as you can see in the changes.

Technical highlight/advice

How to test my changes

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@jonas-martinez jonas-martinez added the bug Something isn't working label Dec 11, 2023
@jonas-martinez jonas-martinez self-assigned this Dec 11, 2023
@taorepoara taorepoara merged commit ceaee02 into main Dec 11, 2023
17 checks passed
@taorepoara taorepoara deleted the fix-oauth-ios branch December 11, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants