Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Match baseSize changes on lenra_components #43

Merged
merged 2 commits into from
Sep 12, 2022
Merged

feat: Match baseSize changes on lenra_components #43

merged 2 commits into from
Sep 12, 2022

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented Sep 12, 2022 •
edited
Loading

#__

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I included unit tests that cover my changes
  • I added/updated the documentation about my changes
  • I made my own code-review before requesting one

Description of the changes

Technical highlight/advice

@jonas-martinez jonas-martinez added the enhancement New feature or request label Sep 12, 2022
@jonas-martinez jonas-martinez self-assigned this Sep 12, 2022
taorepoara
taorepoara requested changes Sep 12, 2022
View reviewed changes
lib/views/simple_page.dart Outdated Show resolved Hide resolved
taorepoara
taorepoara approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@taorepoara taorepoara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonas-martinez jonas-martinez merged commit 9de1e65 into beta Sep 12, 2022
@jonas-martinez jonas-martinez deleted the match-baseSize-changes branch September 12, 2022 15:01
@shiipou
Copy link
Contributor

shiipou commented Sep 12, 2022

🎉 This PR is included in version 1.0.0-beta.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Aug 11, 2023

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

taorepoara pushed a commit that referenced this pull request Sep 29, 2023
@jonas-martinez @taorepoara
feat: Match baseSize changes on lenra_components (#43)
8e1f023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taorepoara taorepoara taorepoara approved these changes

Assignees

@jonas-martinez jonas-martinez

Labels
enhancement New feature or request released on @alpha released on @beta
Projects
Lenra
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonas-martinez @shiipou @taorepoara