Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: App context in login/register page #83

Merged
merged 23 commits into from
May 31, 2023
Merged

feat: App context in login/register page #83

merged 23 commits into from
May 31, 2023

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented May 19, 2023 •
edited by taorepoara
Loading

Linked to lenra-io/client#69

Description of the changes

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

Technical highlight/advice

@jonas-martinez jonas-martinez added the enhancement New feature or request label May 19, 2023
@jonas-martinez jonas-martinez self-assigned this May 19, 2023
@jonas-martinez jonas-martinez changed the title feat: App context in login/register page [WIP] feat: App context in login/register page May 19, 2023
@jonas-martinez jonas-martinez mentioned this pull request May 22, 2023
Closed
6 tasks
@jonas-martinez jonas-martinez changed the title [WIP] feat: App context in login/register page feat: App context in login/register page May 23, 2023
taorepoara
taorepoara requested changes May 24, 2023
View reviewed changes
lib/navigator/common_navigator.dart Show resolved Hide resolved
lib/views/auth/auth_page.dart Outdated Show resolved Hide resolved
lib/views/auth/auth_page.dart Outdated Show resolved Hide resolved
lib/views/auth/auth_page_form.dart Outdated Show resolved Hide resolved
lib/views/auth/auth_page_form.dart Outdated Show resolved Hide resolved
lib/views/cgu/cgu_page.dart Show resolved Hide resolved
lib/views/login/login_form.dart Outdated Show resolved Hide resolved
lib/views/verify_code/verifiying_code_page.dart Show resolved Hide resolved
pubspec.yaml Show resolved Hide resolved
@taorepoara
Copy link
Member

Is there a way to try this new login page locally ?

@jonas-martinez
Copy link
Collaborator Author

Is there a way to try this new login page locally ?

@taorepoara Sure ! You can run the server locally as usual, use client-common with this branch (make sure to use your local lenra_ui_runner in the dependencies), and use the client with this branch as a local dependency for client-common.

You can use this branch for the client lenra-io/client#71

taorepoara
taorepoara requested changes May 25, 2023
View reviewed changes
test/views/login_page_test.dart Show resolved Hide resolved
lib/api/response_models/app_response.dart Outdated Show resolved Hide resolved
jonas-martinez and others added 2 commits May 26, 2023 17:18
@jonas-martinez @taorepoara
Update lib/api/response_models/app_response.dart
53946df 
Co-authored-by: Thomas DA ROCHA <thomas.darocha@lenra.io>
@jonas-martinez
Add test for authpage
5bf0689
@jonas-martinez
Copy link
Collaborator Author

jonas-martinez commented May 26, 2023 •
edited
Loading

Make the login button bigger.
Align the keep me logged in to the left.

EDIT: This has been done 👍

taorepoara
taorepoara approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@taorepoara taorepoara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK

@jonas-martinez jonas-martinez merged commit b697fc3 into beta May 31, 2023
@jonas-martinez jonas-martinez deleted the app-context-login-register branch May 31, 2023 14:33
@shiipou
Copy link
Contributor

shiipou commented May 31, 2023

🎉 This PR is included in version 1.0.0-beta.41 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Aug 11, 2023

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

taorepoara pushed a commit that referenced this pull request Sep 29, 2023
@jonas-martinez @taorepoara
feat: App context in login/register page (#83)
a4a7e60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taorepoara taorepoara taorepoara approved these changes

Assignees

@jonas-martinez jonas-martinez

Labels
enhancement New feature or request released on @alpha released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonas-martinez @taorepoara @shiipou