[Bug]: Unexpected behavior when running same API request multiple times

[jonas-martinez]

What happened?

It seems that our current API request system using the models produces an unexpected behavior when running the same API request multiple times (no matter the parameters as long as the Status variable is the same for the requests).

This must be due to the way we handle request statuses. In fact we use a class variable for the Status which means that if two same requests run concurrently it will try to update the same Status variable. The first request to finish will be ok but the second will just not run the request and fetch the result from the first (because the status was updated to done).

A possible solution

Define the Status variables inside of the method that runs the request. This will ensure that two requests cannot edit the same Status at the same time.
This means that we must change where we use the status to observe the state of the request to use the Future's result instead. This should not be a problem.

Before

class Example {
  Status<GetMainEnvResponse> getMainEnvStatus = Status();
  
  Future<GetMainEnvResponse> getMainEnv(int appId) async {
      var res = await getMainEnvStatus.handle(
        () => ApplicationApi.getMainEnv(appId),
        notifyListeners,
      );
      mainEnv = res.mainEnv;
      notifyListeners();
      return res;
    }
}

After

Future<GetMainEnvResponse> getMainEnv(int appId) async {
    Status<GetMainEnvResponse> getMainEnvStatus = Status();
    var res = await getMainEnvStatus.handle(
      () => ApplicationApi.getMainEnv(appId),
      notifyListeners,
    );
    mainEnv = res.mainEnv;
    notifyListeners();
    return res;
  }

[jonas-martinez]

We could still use the Status as a class variable for the requests that will not be run simultaneously anyway. Or can be run simultaneously and will not alter the final result.

[jonas-martinez]

After some discussions with @taorepoara we could just use a Map with the appId as key and the status as value for the example shown above. And replicate this solution where we need it.