Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update the todo list app guide #106

Merged
merged 4 commits into from
May 31, 2023

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented May 25, 2023

Closes #104

Description of the changes

Update the todo list app guide to correspond to the last months modifications.
Also add the use of the app lib.
I've moved the corresponding image in a specific directory.

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara added the documentation Improvements or additions to documentation label May 25, 2023
@taorepoara taorepoara self-assigned this May 25, 2023
@taorepoara taorepoara linked an issue May 25, 2023 that may be closed by this pull request
@taorepoara taorepoara marked this pull request as ready for review May 25, 2023 15:32
src/markdown/guides/todo-list-app.md Outdated Show resolved Hide resolved
src/markdown/guides/todo-list-app.md Outdated Show resolved Hide resolved
src/markdown/guides/todo-list-app.md Outdated Show resolved Hide resolved
src/markdown/guides/todo-list-app.md Outdated Show resolved Hide resolved
src/markdown/guides/todo-list-app.md Outdated Show resolved Hide resolved
Co-authored-by: Jonas Martinez <36544012+jonas-martinez@users.noreply.github.com>
@taorepoara taorepoara merged commit 74e898f into beta May 31, 2023
@taorepoara taorepoara deleted the 104-task-update-the-todo-list-guide branch May 31, 2023 12:39
@shiipou
Copy link
Contributor

shiipou commented May 31, 2023

🎉 This PR is included in version 1.0.0-beta.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

taorepoara added a commit that referenced this pull request Oct 25, 2023
* feat: Update the todo list app guide

* fix json format

* Apply suggestions from code review

Co-authored-by: Jonas Martinez <36544012+jonas-martinez@users.noreply.github.com>

---------

Co-authored-by: Jonas Martinez <36544012+jonas-martinez@users.noreply.github.com>
Co-authored-by: jonas-martinez <cbobbxta.fr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update the Todo list guide
3 participants