Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load components pages to build the doc #62

Merged
merged 15 commits into from
Oct 25, 2022

Conversation

shiipou
Copy link
Contributor

@shiipou shiipou commented Sep 16, 2022

Signed-off-by: shiipou shiishii@nocturlab.fr

#__

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I included unit tests that cover my changes
  • I added/updated the documentation about my changes
  • I made my own code-review before requesting one

Description of the changes

Technical highlight/advice

@shiipou shiipou added the enhancement New feature or request label Sep 16, 2022
@shiipou shiipou self-assigned this Sep 16, 2022
@shiipou shiipou linked an issue Sep 16, 2022 that may be closed by this pull request
@shiipou shiipou changed the title [WIP] feat: allow to load multiple api from components.yml file [WIP] feat: load components pages to build the doc Sep 16, 2022
Signed-off-by: shiipou <shiishii@nocturlab.fr>
Signed-off-by: shiipou <shiishii@nocturlab.fr>
TODO: I need to find info in the .json for title, etc when it got fixed

Signed-off-by: shiipou <shiishii@nocturlab.fr>
Signed-off-by: shiipou <shiishii@nocturlab.fr>
Signed-off-by: shiipou <shiishii@nocturlab.fr>
@shiipou shiipou force-pushed the 61-load-components-pages-to-build-the-doc branch from 4cf782b to 0e8c4be Compare October 14, 2022 13:06
Signed-off-by: shiipou <shiishii@nocturlab.fr>
Signed-off-by: shiipou <shiishii@nocturlab.fr>
Signed-off-by: shiipou <shiishii@nocturlab.fr>
Signed-off-by: shiipou <shiishii@nocturlab.fr>
Signed-off-by: shiipou <shiishii@nocturlab.fr>
@shiipou shiipou requested review from taorepoara and jonas-martinez and removed request for taorepoara October 17, 2022 14:43
@shiipou shiipou changed the title [WIP] feat: load components pages to build the doc feat: load components pages to build the doc Oct 17, 2022
.scripts/components.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/utils/views.js Outdated Show resolved Hide resolved
Signed-off-by: shiipou <shiishii@nocturlab.fr>
Signed-off-by: shiipou <shiishii@nocturlab.fr>
Copy link
Contributor

@jonas-martinez jonas-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shiipou shiipou merged commit 18b66f9 into main Oct 25, 2022
@shiipou shiipou deleted the 61-load-components-pages-to-build-the-doc branch October 25, 2022 21:13
@shiipou
Copy link
Contributor Author

shiipou commented Dec 27, 2022

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor Author

shiipou commented Oct 25, 2023

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load components pages to build the doc
3 participants