Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Crons #85

Merged
merged 3 commits into from
Mar 3, 2023
Merged

feat: Crons #85

merged 3 commits into from
Mar 3, 2023

Conversation

jonas-martinez
Copy link
Contributor

Closes #

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I included unit tests that cover my changes
  • I added/updated the documentation about my changes
  • I made my own code-review before requesting one

Description of the changes

Technical highlight/advice

@jonas-martinez jonas-martinez added the documentation Improvements or additions to documentation label Mar 1, 2023
@jonas-martinez jonas-martinez self-assigned this Mar 1, 2023
@taorepoara
Copy link
Member

This project is a doc project so the commit type should not be docs (unless you document the project it self, like editing the README).

@taorepoara
Copy link
Member

This to technical. We will have a specific part in the references to describe the API, but here you should describe at least one use case I think

@jonas-martinez jonas-martinez changed the title docs: Crons feat: Crons Mar 2, 2023
@jonas-martinez jonas-martinez requested review from taorepoara and removed request for taorepoara March 2, 2023 19:59
@jonas-martinez
Copy link
Contributor Author

@taorepoara I did some changes so that it is less technical about the API. I added some documentation about how the 5 star cron format works (* * * * *).

@taorepoara taorepoara merged commit ebda324 into beta Mar 3, 2023
@taorepoara taorepoara deleted the crons branch March 3, 2023 08:48
@shiipou
Copy link
Contributor

shiipou commented Mar 3, 2023

🎉 This PR is included in version 1.0.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

taorepoara pushed a commit that referenced this pull request Oct 25, 2023
* docs: Crons

* Rework the doc for crons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released on @beta
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants