Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load config before dev in terminal #406

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented May 15, 2024

About this PR

Closes #328

Technical highlight/advice

Loads the config file before the dev command.

How to test my changes

Start a terminal:

lenra

Then run the dev command:

dev

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara self-assigned this May 15, 2024
@taorepoara taorepoara marked this pull request as ready for review May 15, 2024 15:34
@taorepoara taorepoara merged commit 9d2ab41 into beta May 15, 2024
11 checks passed
@taorepoara taorepoara deleted the 328-path-terminal branch May 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant