Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MenuItem icon spacing #117

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix: MenuItem icon spacing #117

merged 1 commit into from
Sep 15, 2022

Conversation

jonas-martinez
Copy link
Contributor

@jonas-martinez jonas-martinez commented Sep 14, 2022 •
edited
Loading

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I included unit tests that cover my changes
  • I added/updated the documentation about my changes
  • I made my own code-review before requesting one

Description of the changes

After removing the bsaeSize factor for spacings, we forgot to change the menuItem icon spacing from 1 to 8.

@jonas-martinez jonas-martinez added the bug Something isn't working label Sep 14, 2022
@jonas-martinez jonas-martinez self-assigned this Sep 14, 2022
@taorepoara taorepoara merged commit 2643bf1 into beta Sep 15, 2022
@taorepoara taorepoara deleted the fix-menu-icon-spacing branch September 15, 2022 05:49
@shiipou
Copy link
Contributor

shiipou commented Sep 15, 2022

🎉 This PR is included in version 1.0.0-beta.49 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taorepoara taorepoara taorepoara approved these changes

Assignees

@jonas-martinez jonas-martinez

Labels
bug Something isn't working released on @beta
Projects
Lenra
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonas-martinez @shiipou @taorepoara