Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add service for get latest Cgu #139

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Conversation

ClementGld
Copy link
Contributor

No description provided.

@ClementGld ClementGld self-assigned this Mar 8, 2022
@ClementGld ClementGld added the enhancement New feature or request label Mar 8, 2022
@ClementGld ClementGld linked an issue Mar 8, 2022 that may be closed by this pull request
@ClementGld ClementGld changed the title feat: add service for get latest Cgu [WIP] feat: add service for get latest Cgu Mar 9, 2022
@ClementGld ClementGld changed the title [WIP] feat: add service for get latest Cgu feat: add service for get latest Cgu Mar 9, 2022
Copy link
Member

@Nesqwik Nesqwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good PR, the implementation looks clean and readable. The test is great

Just a few changes for naming consistency :)

apps/lenra/lib/lenra/services/get_latest_cgu.ex Outdated Show resolved Hide resolved
@ClementGld ClementGld requested a review from Nesqwik March 9, 2022 15:05
@Nesqwik Nesqwik merged commit f0d6470 into beta Mar 9, 2022
@Nesqwik Nesqwik deleted the addServiceGetLatestCgu branch March 9, 2022 15:25
@shiipou
Copy link
Contributor

shiipou commented Mar 9, 2022

🎉 This PR is included in version 1.0.0-beta.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Mar 25, 2022

🎉 This PR is included in version 1.0.0-data.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Apr 4, 2023

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@taorepoara
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a service to get the latest CGU
4 participants