-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Login and register forms style #392
feat: Login and register forms style #392
Conversation
Just misses the little eye button to show the password during the register process. May be useful for the login too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check above comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some visual issues :
-
The ">" is wrongly placed and incorrectly colored according to figma
-
The form shift up/down entirely when switching from "login" to "register"
-
when reducing the screen height, the scroll appear vertically AND horizontally instead of vertically only.
I've reproduced all of them in Arc Browser (Chrome-based) and Firefox.
I've resolved this issue in another branch. I let it like that.
This is the wanted behavior: the content is vertically centered in the page as it is in Figma.
I could not reproduce this problem in Chrome nor Firefox. We'll check it again in the next branch. |
Well.. This should not IMO :(
It probably depends of the screen size ? I have a small 13" screen |
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes #388
Description of the changes
Add style to the login and register forms.
I've only implemented the client page since we need more OAuth features to work on back-office and app pages since we need to know which client is calling the page.
Checklist
I included unit tests that cover my changes
I added/updated the documentation about my changes
Technical highlight/advice
Since the password is managed by a different table than the user, we need to adapt the login password field make it work in both situations.