Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Login and register forms style #392

Merged
merged 11 commits into from
Jul 15, 2023

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented Jul 5, 2023

Closes #388

Description of the changes

Add style to the login and register forms.

I've only implemented the client page since we need more OAuth features to work on back-office and app pages since we need to know which client is calling the page.

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

Technical highlight/advice

Since the password is managed by a different table than the user, we need to adapt the login password field make it work in both situations.

@taorepoara taorepoara self-assigned this Jul 5, 2023
@taorepoara taorepoara linked an issue Jul 5, 2023 that may be closed by this pull request
@taorepoara taorepoara marked this pull request as ready for review July 7, 2023 15:51
@jonas-martinez
Copy link
Collaborator

Just misses the little eye button to show the password during the register process. May be useful for the login too.

Copy link
Collaborator

@jonas-martinez jonas-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check above comment

Copy link
Member

@Nesqwik Nesqwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some visual issues :

  • The ">" is wrongly placed and incorrectly colored according to figma
    Capture d’écran 2023-07-13 à 11 34 04

  • The form shift up/down entirely when switching from "login" to "register"
    Enregistrement de l’écran 2023-07-13 à 11 37 32

  • when reducing the screen height, the scroll appear vertically AND horizontally instead of vertically only.
    Enregistrement de l’écran 2023-07-13 à 11 47 01

I've reproduced all of them in Arc Browser (Chrome-based) and Firefox.

@taorepoara
Copy link
Member Author

* The ">" is wrongly placed and incorrectly colored according to figma
  ![Capture d’écran 2023-07-13 à 11 34 04](https://user-images.githubusercontent.com/6428498/253332573-d2cc6aa7-4dcb-4dbd-a6af-a44d7c6fc714.png)

I've resolved this issue in another branch. I let it like that.

* The form shift up/down entirely when switching from "login" to "register"
  ![Enregistrement de l’écran 2023-07-13 à 11 37 32](https://user-images.githubusercontent.com/6428498/253332832-9d51a6dd-3d79-4c09-9f0a-dc75867f7476.gif)

This is the wanted behavior: the content is vertically centered in the page as it is in Figma.

* when reducing the screen height, the scroll appear vertically **AND** horizontally instead of vertically only.
  ![Enregistrement de l’écran 2023-07-13 à 11 47 01](https://user-images.githubusercontent.com/6428498/253333649-ddb0b3eb-1096-4896-91b2-823037b26d71.gif)

I've reproduced all of them in Arc Browser (Chrome-based) and Firefox.

I could not reproduce this problem in Chrome nor Firefox. We'll check it again in the next branch.

@taorepoara taorepoara merged commit 38a091c into beta Jul 15, 2023
3 checks passed
@taorepoara taorepoara deleted the 388-task-implement-the-loginregister-page-design branch July 15, 2023 21:09
@Nesqwik
Copy link
Member

Nesqwik commented Jul 15, 2023

This is the wanted behavior: the content is vertically centered in the page as it is in Figma.

Well.. This should not IMO :(

I could not reproduce this problem in Chrome nor Firefox. We'll check it again in the next branch.

It probably depends of the screen size ? I have a small 13" screen

@taorepoara
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Implement the Login/Register page Design
3 participants