feat: Manage functions requests and limits by env vars #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiipou
previously approved these changes
Oct 2, 2023
|
🎉 This PR is included in version 1.0.0-beta.178 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
The OpenFaaS functions may have some problem with the basic cpu and memory definitions. This allow us to change it with env vars.
How to test my changes
Define one of the 4 env vars:
FAAS_REQUEST_CPUFAAS_REQUEST_MEMORYFAAS_LIMIT_CPUFAAS_LIMIT_MEMORYChecklist
I included unit tests that cover my changes
I added/updated the documentation about my changes