Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove initialisation container from build pipeline (k8s version) #478

Merged

Conversation

shiipou
Copy link
Contributor

@shiipou shiipou commented Oct 2, 2023

About this PR

Closes #477

In this PR I just merged each step of the build pipeline in only one step (build)
So it take a lot less disk space and less time to start.

Technical highlight/advice

How to test my changes

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

Signed-off-by: shiipou <shiishii@nocturlab.fr>
@shiipou shiipou self-assigned this Oct 2, 2023
@shiipou shiipou linked an issue Oct 2, 2023 that may be closed by this pull request
shiipou and others added 2 commits October 2, 2023 17:16
Signed-off-by: shiipou <shiishii@nocturlab.fr>
@shiipou shiipou merged commit 34efddf into beta Oct 3, 2023
4 checks passed
@shiipou shiipou deleted the 477-task-remove-init-container-to-free-storage-when-build-fail branch October 3, 2023 08:46
@taorepoara
Copy link
Member

🎉 This PR is included in version 1.0.0-beta.180 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou shiipou linked an issue Oct 3, 2023 that may be closed by this pull request
@taorepoara
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants