fix: This ensure that all timestamps in ecto are :utc_datetime #94
Conversation
Nesqwik
requested review from
jonas-martinez and
shiipou
and removed request for
jonas-martinez
| @@ -16,6 +16,8 @@ import Config | |||
| config :lenra, | |||
| ecto_repos: [Lenra.Repo] | |||
|
|
|||
| config :lenra, Lenra.Repo, migration_timestamps: [type: :utc_datetime] | |||
There was a problem hiding this comment.
You set this config line but I cannot see where this is used, can you give me some insight @Nesqwik ? (You already set it in the schema.ex file)
There was a problem hiding this comment.
Sure !
There is two config that have to be done :
- The first one, this one, is the Migration configuration. This tell to ecto to use :utc_datetime by default for timestamps() macro in migration (in postgres table) instead of the :naive_datetime.
- The second one in schema.ex ask the schema (Elixir representation of the tables) to retrieve the field in the database into a DateTime instead of NaiveDateTime.
The difference is that DateTime contain the timezone information and NaiveDateTime doesn't. This should help us with all the timezone issue.
There was a problem hiding this comment.
|
🎉 This PR is included in version 1.0.0-beta.17 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This might (or might not) fix #92
I'm unable to reproduce the error locally but since we now ask ecto to use timestamps with timezone, all timezone error should be fixed... hopefully...
I've used a custom Lenra.Schema for every schema with default :utc_datetime & configure ecto to get :utc_datetime in migration for all future migrations. Then i've change all current table to use :utc_datetime instead of :naive_datetime for updated_at and inserted_at columns.