Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modification image ratio and add line meta #28

Closed
wants to merge 10 commits into from

Conversation

Nesqwik
Copy link
Member

@Nesqwik Nesqwik commented May 23, 2022

No description provided.

@Nesqwik Nesqwik linked an issue May 23, 2022 that may be closed by this pull request
@Nesqwik Nesqwik requested a review from taorepoara May 23, 2022 07:43
@Nesqwik
Copy link
Member Author

Nesqwik commented Jun 1, 2022

@Thibault5 In case your branch is ready to be merged

You must follow the Conventionnal commit convention for the PR title in order the checks to succeed.

Since you only have one commit, your commit must follow the same convention too.
You can update the commit message with the following steps :

  • git checkout <branch-name> to go to your local branch name.
  • Ensure you are up to date with git pull origin <branch-name>
  • Then edit the commit message with git commit --amend and save.
  • Finally send your new git history with git push --force

⚠️ This will erase the entire distant branch with your new git history ! Use this with care !

If you need help, please message me or any of the lenra dev team member ;)

@Thibault5 Thibault5 changed the title modification ratio image + ajout ligne meta feat: modification image ratio and add line meta Jun 13, 2022
@Thibault5 Thibault5 force-pushed the 23-link-image-preview-shows-ovh-logo branch from caccdc8 to 331703c Compare June 13, 2022 08:00
@taorepoara
Copy link
Member

@Nesqwik Can you eview this, please ?

@Nesqwik
Copy link
Member Author

Nesqwik commented Aug 2, 2022

The Title for Facebook and Linkedin are OK.
The title for Twitter is cropped...
The description for twitter is cropped too.

The image have the wrong size for all the social media...
We should add different images for different social media.

For a technical point of view, it seems ok. But visually it's not perfect.

@Thibault5 Can you give us a reference for best practices ? A article/doc about this ?
Can you validate this to @Alienor-Lenra too ? thx :)

Capture d’écran 2022-08-02 à 09 15 00

Capture d’écran 2022-08-02 à 09 15 17

Capture d’écran 2022-08-02 à 09 15 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage social network previews
5 participants