You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Your implementation of "Login via Github" is broken. You force Github username to be used as Lens ID, but you don't handle collisions where a Github username collides with an existing Lens ID (e.g., mine).
To Reproduce
When attempting to use Lens, I am coerced to log in with a Lens ID. When I attempt to sign in via Github auth, I am told that a user account already exists, and I am presented with a single-button modal prompt:
User with username emmanuel already exists. [Link to Existing Account].
When I click Link to Existing Account, I am present with a dialog indicating that sign in instructions have been sent via email.
No such instructions were sent. At least, not to my email address.
I can only assume that someone else has created a Lens ID that matches my Github username, and that the "Login via Github" flow naively assumes that Github username == Lens ID, when that is not enforced (possible to create a non-Github Lens ID that collides with/shadows an existing Github username) and therefore is clearly a faulty assumption.
Expected behavior
I expect the Lens ID system to have accounted for basic/fundamental issues like name collisions when handling identifiers from different namespaces (Github usernames vs Lens IDs).
More specifically, I expect the login flow to provide a route to create a non-colliding (unique) Lens ID using "Login via Github", even when the value of a Github username has already been claimed as a Lens ID.
Or better, don't assume it is safe to use a natural key/external identifier as a Lens ID (i.e., Github username). Instead, either 1) use something globally unique as the Lens ID (e.g., email address), or 2) use a synthetic identifier and avoid collisions.
Screenshots
See above, inline.
Environment (please complete the following information):
Lens ID account creation / login flow on the website
Logs:
n/a
Kubeconfig:
n/a
Additional context
n/a
The text was updated successfully, but these errors were encountered:
We are currently in the process of revising the sign-up/sign-in flow. I’ll make sure to provide you with an update as soon as the changes go live. Your use case should then be fixed as well.
Describe the bug
Your implementation of "Login via Github" is broken. You force Github username to be used as Lens ID, but you don't handle collisions where a Github username collides with an existing Lens ID (e.g., mine).
To Reproduce
When attempting to use Lens, I am coerced to log in with a Lens ID. When I attempt to sign in via Github auth, I am told that a user account already exists, and I am presented with a single-button modal prompt:
When I click
Link to Existing Account
, I am present with a dialog indicating that sign in instructions have been sent via email.No such instructions were sent. At least, not to my email address.
I can only assume that someone else has created a Lens ID that matches my Github username, and that the "Login via Github" flow naively assumes that Github username == Lens ID, when that is not enforced (possible to create a non-Github Lens ID that collides with/shadows an existing Github username) and therefore is clearly a faulty assumption.
Expected behavior
I expect the Lens ID system to have accounted for basic/fundamental issues like name collisions when handling identifiers from different namespaces (Github usernames vs Lens IDs).
More specifically, I expect the login flow to provide a route to create a non-colliding (unique) Lens ID using "Login via Github", even when the value of a Github username has already been claimed as a Lens ID.
Or better, don't assume it is safe to use a natural key/external identifier as a Lens ID (i.e., Github username). Instead, either 1) use something globally unique as the Lens ID (e.g., email address), or 2) use a synthetic identifier and avoid collisions.
Screenshots
See above, inline.
Environment (please complete the following information):
Lens ID account creation / login flow on the website
Logs:
n/a
Kubeconfig:
n/a
Additional context
n/a
The text was updated successfully, but these errors were encountered: