Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible mistake on the version number #11

Open
mindsers opened this issue Aug 22, 2019 · 7 comments
Open

Possible mistake on the version number #11

mindsers opened this issue Aug 22, 2019 · 7 comments

Comments

@mindsers
Copy link
Contributor

mindsers commented Aug 22, 2019

After new release was published, I tried to update the package but neither yarn nor npm knows the new version.

I looked for the git tags in github but didn't find it. Then I looked at npm's version list and got this:

  • 2.0.1 (2 hours ago)
  • 2.1.0 (8 months ago)

As yarn and npm use/understand semver, they don't see 2.0.1 as a new version after 2.1.0. I think the version number should be 2.1.1.


@zackify Is there a mistake on the version number?

Originally posted by @mindsers in #10 (comment)

@zackify
Copy link
Collaborator

zackify commented Aug 22, 2019

I wasn’t aware that a 2.1.0 was released and yet the package.json on master said 2.0.0. I’ll have to do a new release tomorrow. Sorry about that. As you can tell this isn’t my repo but I got added as a collaborator a while ago haha

@mindsers
Copy link
Contributor Author

No problem! I just write the problem here to be solved at some point and we don't forget about it. 😃

As a workaround until it's solved, we can (force) install the package at the version 2.0.1 specifically.

yarn add graphql-tag.macro@2.0.1

@mindsers
Copy link
Contributor Author

mindsers commented Sep 4, 2019

@zackify Hi! Is there anything new about this?

@leoasis
Copy link
Owner

leoasis commented Sep 10, 2019

Happy to get a PR that includes this change! Should be an easy one :)

@zackify
Copy link
Collaborator

zackify commented Sep 10, 2019

Sorry for not replying sooner. I’ve been on vacation with my laptop out of reach or I would have released it already

@mindsers
Copy link
Contributor Author

mindsers commented Sep 10, 2019

@leoasis a PR for what? It seems the needed code is already on master(#10).

@pdemarino
Copy link

Hi - same comment here. Any chance this can be pushed out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants