Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the code #4

Open
3 of 5 tasks
leomichalski opened this issue Sep 9, 2022 · 0 comments
Open
3 of 5 tasks

Clean the code #4

leomichalski opened this issue Sep 9, 2022 · 0 comments

Comments

@leomichalski
Copy link
Owner

leomichalski commented Sep 9, 2022

The flight control code has some smart tricks but is a complete mess. It needs to be refactored into multiple .cpp and .hpp files. It also needs more methods and, maybe, classes (maybe c-style classes).

The vision code (Python) is almost pseudo-code but is poorly documented beyond that. It is weird to keep the "GazeboVideoSource" class inside the "rosbridge.py" file when there is a file named "videosource.py", refactor that.

I won't even write about the "scripts" wtf folder.

Tasks:

  • Refactor the flight control C++ code.
  • Stop hardcoding everything (takeoff height, waypoints, etc) in the aruco_hunter package. Use a roslaunch file and calculate the waypoints before taking off.
  • Document the vision code properly.
  • Remove some code smells from the vision code.
  • Clean the scripts folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant