Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New button configuration not recognized by vscode #195

Open
atakiya opened this issue Mar 25, 2023 · 4 comments · May be fixed by #196
Open

New button configuration not recognized by vscode #195

atakiya opened this issue Mar 25, 2023 · 4 comments · May be fixed by #196
Labels
wontfix This will not be worked on

Comments

@atakiya
Copy link

atakiya commented Mar 25, 2023

I've left a comment on the original PR introducing this feature, but here's an issue just for organization's sake.

About

The configuration entry for vscord.status.buttons introduced by #183 (d689dfb) is not recognized by vscode, despite working as intended.

See linked image below
image

Possibly caused by 817fa07
@xhayper
Copy link
Collaborator

xhayper commented Mar 25, 2023

The reason why i switch over to the one in 817fa07 is because we benefit from json schema which will validate user input, in reality, both should work except the .buttons": {} have no safety.

@xhayper xhayper added the wontfix This will not be worked on label Mar 25, 2023
@atakiya
Copy link
Author

atakiya commented Mar 25, 2023

The reason why i switch over to the one in 817fa07 is because we benefit from json schema which will validate user input, in reality, both should work except the .buttons": {} have no safety.

Theoretically you should be able to add type checking for the buttons objects as well, without impeding the other one.
But I do must admit that I haven't worked with vscode extension development yet, this is pure speculation on my part.
I might look into it when i got some time myself - if you got no plans to fix this, then feel free to close.

@xhayper
Copy link
Collaborator

xhayper commented Mar 25, 2023

I might actually look into this, but the first time we did it, it kinda didn't type check for us, sadly.

@atakiya atakiya linked a pull request Mar 25, 2023 that will close this issue
Open
@atakiya
Copy link
Author

atakiya commented Mar 25, 2023

I've got it working in #196 - it really just needed a proper JSON-schema-like definition to be made.
See the PR for a couple problems I think that might crop up - its nothing code-breaking, but more a general maintenance and usability worry of my own opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new button configuration schema atakiya/vscord
2 participants
@atakiya @xhayper