Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use-python3-shebang.patch (Update shebang to Python 3 to fix Lintian warnings) #3088

Open
iikrllx opened this issue Jan 28, 2025 · 1 comment
Labels

Comments

@iikrllx
Copy link

iikrllx commented Jan 28, 2025

Description

Hi, I am trying to add your software to Debian package and I found some warnings from Lintian utility.

Description: Update shebang to Python 3 to fix Lintian warnings

  • unusual-interpreter python
  • executable-not-elf-or-script

This patch fix it:

--- vim-vimtex-2.16.orig/autoload/vimtex/complete/tools/convert-cwl
+++ vim-vimtex-2.16/autoload/vimtex/complete/tools/convert-cwl
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 """Convert texstudio cwl files to VimTeX format"""
 import os
 import re
--- vim-vimtex-2.16.orig/autoload/vimtex/complete/tools/symbols-merge.py
+++ vim-vimtex-2.16/autoload/vimtex/complete/tools/symbols-merge.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 """Add symbols to complete files"""
 import os
 
--- vim-vimtex-2.16.orig/autoload/vimtex/complete/tools/symbols-parse-json.py
+++ vim-vimtex-2.16/autoload/vimtex/complete/tools/symbols-parse-json.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python3
 """Blahrg."""
 import json

Steps to reproduce

No response

Expected behavior

No response

Actual behavior

No response

Do you use a latexmkrc file?

No

VimtexInfo

System info:
  OS: Debian GNU/Linux trixie/sid
  Vim version: VIM 9.1 (1-948, 950-967)
  Has clientserver: false

VimTeX project: example
  base: example.tex
  root: /home/builder
  tex: /home/builder/example.tex
  main parser: current file verified
  document class: article
  compiler: latexmk
    engine: -pdf
    options:
      -verbose
      -file-line-error
      -synctex=1
      -interaction=nonstopmode
    callback: 1
    continuous: 1
    executable: latexmk
  viewer: Zathura
    xwin id: 0
  qf method: LaTeX logfile
@iikrllx iikrllx added the bug label Jan 28, 2025
@lervag
Copy link
Owner

lervag commented Jan 28, 2025

Hi, I am trying to add your software to Debian package and I found some warnings from Lintian utility.

Huh, I'm curious, why do you want to do that?

In my humble, but strong, opinion, you really should not put Vim/neovim plugins in distribution packages. Users should install plugins explicitly in their own configuration.

The main reason I have this strong opinion: When users install plugins through package managers (e.g. with Debian, Ubuntu, etc), they are often not really aware of which packages they have. They may later try to install things manually or in a different way and then experience conflicts that are hard to notice. These conflicts are hard to notice because the user often forgets about the packages installed in the system. For instance, if I were to ask for their Vim configuration, they show me their .vimrc or .config/neovim/init.lua - things look right, but still don't work as expected. They have to use e.g. :scriptnames before I notice that there are surprising scripts being loaded.

It's hard to find among ~3000 issues, but here are some issues related to people not being aware they had conflicting packages installed:

I am quite confident that there are more of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants