Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow proper rebasing #16

Open
matthieusieben opened this issue Mar 17, 2016 · 3 comments
Open

Allow proper rebasing #16

matthieusieben opened this issue Mar 17, 2016 · 3 comments

Comments

@matthieusieben
Copy link

This plugin should specify the relativeTo and target clean-css options in order to allow proper rebasing.

@seven-phases-max
Copy link
Member

Well, the plugin is only wrapper of clean-css, it does not really knows anything about CSS code it passes through, so if clean-css itself does not provide these options then the plugin can do nothing about it.

@matthieusieben
Copy link
Author

Please see target and relativeTo

@seven-phases-max
Copy link
Member

I see. (Now I wonder why CLI options are hardcoded by the plugin tinsel at all. It seems to be quite tedious to sync https://github.com/less/less-plugin-clean-css/blob/master/lib/parse-options.js to https://github.com/jakubpawlowicz/clean-css/blob/master/bin/cleancss each time a new option is in. Should not we switch just to passing JS-named-options through? (with corresponding exceptions of course)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants