inline and less imports of the same name = race condition

[thorn0]

Stumbled upon this working on webpack-contrib/less-loader#242.
See an instance of the mentioned race condition here: https://ci.appveyor.com/project/webpack-contrib/less-loader/build/1.0.46/job/mbywf90cimqkjee5

It happens when processing files like this:

@import (less) "some/css.css";
@import (inline) "some/css.css";

[seven-phases-max]

I'm not sure I actually understand the issue... Could you elaborate please?
Is this about once/multiple?

[thorn0]

It's about less vs inline. Processed imports are cached in files by their paths. However, inline issues aren't parsed. Instead their root property contains an unparsed string. If two imports of the same name start being processed and the inline one gets processed first, the less one isn't parsed. An entry created for the inline one is retrieved from files and things go wrong. Code gets a string where an object is expected. My patch prevents inline imports from storing in files. They aren't reused from there anyway.

A better solution would be not to use only path as a key for files, queue, and probably other places and take import options into account too. BTW, is this queue property actually used anywhere?

[seven-phases-max]

I see. So... is anything of these: 1, 2, 3 is changed with this patch (or not working in 3.x w/o it)?
If there's difference we need to know if something should be reflected in the docs.

[thorn0]

(1) and (2) sometimes don't work (an exception is thrown) without it. That's it.

[seven-phases-max]

I see. So the issue is a sort of #1898 replica.

[seven-phases-max]

Thanks.

[matthew-dean]

Sounds like a bug I may have introduced. I added caching to files in 3.x. Good catch.

[thorn0]

Can we possibly have a 3.0.2 release?