Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling required parentheses for mixin calls? #3584

Closed
urikalish opened this issue Jan 4, 2021 · 6 comments
Closed

Disabling required parentheses for mixin calls? #3584

urikalish opened this issue Jan 4, 2021 · 6 comments

Comments

@urikalish
Copy link

We're considering an upgrade (v3.13.1 --> v4.0.0), but have thousands of old-style no-parentheses mixin calls in our current code.
Is it possible to disable this in some way?

@matthew-dean
Copy link
Member

It's a change in parser code, so no, there's not currently a way to disable it.

Just so you know, the last, most recent v3 release and v4 are nearly identical and were released close together. v4 has the paren requirement, the parens-division default setting for math, and a few other minor things.

@urikalish
Copy link
Author

I understand. Thank you for the quick reply.

@matthew-dean
Copy link
Member

Maybe this change was too aggressive in the interest of syntactic conformity? I'm going to keep this open as something that would accept a PR with an option.

@matthew-dean
Copy link
Member

I'm gonna roll back the parens requirement

@matthew-dean
Copy link
Member

matthew-dean commented Jan 10, 2021

4.1.0 released with the mixin paren requirement rolled back. Hope that helps! https://github.com/less/less.js/releases/tag/v4.1.0

@urikalish
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants