Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /admin/users route paginated #1156

Closed
sarahwooders opened this issue Mar 16, 2024 · 4 comments
Closed

Make /admin/users route paginated #1156

sarahwooders opened this issue Mar 16, 2024 · 4 comments
Labels

Comments

@sarahwooders
Copy link
Collaborator

This will cause issues for a large number of users without pagination https://memgpt.readme.io/reference/get_all_users_admin_users_get

@ajanitshimanga
Copy link
Contributor

ajanitshimanga commented May 26, 2024

Hi! I'd like to pick up this issue. Is there need for a particular type of pagination (Offset-Based Pagination / Cursor-based pagination)?

Can you provide more information on intended functionality / experience using the endpoint? I imagine cursor-based pagination is what is expected here, is this accurate?

@sarahwooders
Copy link
Collaborator Author

It would be great if we could do something similar to how we do paginated retrieval for agent messages:
https://github.com/cpacker/MemGPT/blob/main/memgpt/server/rest_api/agents/message.py#L94

The purpose of the endpoint is so that when we eventually have an admin panel, the administrator and page through the users, as there may be a large number of users in total.

@ajanitshimanga
Copy link
Contributor

@sarahwooders Can this be closed now?

Copy link

github-actions bot commented Dec 6, 2024

This issue has been automatically closed due to 60 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants