Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gmail sender content not being fully removed #23

Open
bittercoder opened this issue Mar 12, 2024 · 0 comments
Open

Gmail sender content not being fully removed #23

bittercoder opened this issue Mar 12, 2024 · 0 comments

Comments

@bittercoder
Copy link

bittercoder commented Mar 12, 2024 •
edited
Loading

Hi!

Thanks to the lever team for building (and sharing) this really useful library!

I've recently found an issue with processing gmail messages where the email address is a hyperlink rather than plain text is causing a small amount of the content in the quoted messages sender line (effective the closing angle bracket of the <a></a> tag is included and any text after that up to the <br> within the same div.

Here are a couple of examples, first one that works correctly - this only returns the content in the body "Example message - there should be quoted content below (gmail style)"

<html>
<body>

Example message - there should be quoted content below (gmail style)

<div class="gmail_quote">
    <div dir="ltr" class="gmail_attr">On Thu, Nov 23, 2023 at 1:03 PM Sam Sampson &lt;sam@testsampson.com&gt; wrote:<br></div>
    <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
        <div dir="ltr">
            Hi Gentlemen,<div><br></div>
            <div>Pleasure speaking with you all today. I''ve got your proposal running through finance as we speak 
            and should, hopefully, have a DocuSign out for you later today.
            </div>
        </div>
    </blockquote>
</div>
</body>
</html>

And then this is an example of one that does not work correctly:

<html>
<body>

Example message - there should be quoted content below (gmail style)


<div class="gmail_quote">
    <div dir="ltr" class="gmail_attr">On Thu, Nov 23, 2023 at 1:03 PM Sam Sampson &lt;<a 
 href="mailto:sam@testsampson.com">sam@testsampson.com</a>&gt; wrote:<br></div>
    <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
        <div dir="ltr">
            Hi Gentlemen,<div><br></div>
            <div>Pleasure speaking with you all today. I''ve got your proposal running through finance as we speak 
            and should, hopefully, have a DocuSign out for you later today.
            </div>
        </div>
    </blockquote>
</div>
</body>
</html>

This returns:

<html>
<body>

Example message - there should be quoted content below (gmail style)

<div class="gmail_quote">
  <div dir="ltr" class="gmail_attr">
    > wrote:</br>
  </div>
</div>

Let me know if you need any further details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bittercoder