-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import of Unimod schema crashes when Unimod is down #128
Comments
It was decided in #82 to not bundle a copy of Unimod with Pyteomics, but to let other libraries that depend upon it being available even when the Unimod web server is not can bundle a specific version with their code and use Relevant piece from the documentation: https://pyteomics.readthedocs.io/en/latest/api/proforma.html#cv-disk-caching |
Thank you @mobiusklein for the recap. Indeed, I was hesitant of including the copy of Unimod and increasing the distribution size 10-fold, even though it's still not a lot. I am still open to ideas though. I realize that the current solution puts some extra load on the users and it doesn't seem ideal. |
One option would be to depend upon the caching and fallback behavior in Another would be to write another caching mechanism in I think going the Some applications might need to keep all their data in one place for easy deletion on uninstall, or they need to keep the reference file consistent so the program doesn't abruptly break because of a remote change. |
@mobiusklein thank you for bearing with me. I looked at As far as I can tell, there are two different mechanisms in there, caching and fallback. While caching needs to be enabled and configured at runtime, fallback to bundled versions is always available and If that is the case and we can add a |
Thank you! 🙏🏼 |
Thanks for the great tool!
I ran today in this issue
Since unimod is down this error is thrown. This impacts lots of tools build on pyteomics (deeplc, ms2pip etc.).
Is there a way to implement a fall-back option if Unimod is not accessible?
Thanks!
The text was updated successfully, but these errors were encountered: