Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen template-haskell version constraint to allow version <2.22 #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Widen template-haskell version constraint to allow version <2.22 #44

wants to merge 1 commit into from

Conversation

nmeum
Copy link

@nmeum nmeum commented Mar 10, 2023 •
edited
Loading

This allows freer-simple to be used with GHC >= 9.4. Prior versions of template-haskell are not compatible with those GHC versions. Newer version of of template-haskell seem to be fully compatible with freer-simple. That is, tests still pass and I haven't noticed any issues in my own project (which use freer-simple).

Fixes #40

If this gets merged, would it be possible to tag a new freer-simple release?

@nmeum
Widen template-haskell version constraint to allow version <2.22
03a367f 
This allows freer-simple to be used with GHC >= 9.4. Prior versions of
template-haskell are not compatible with those GHC versions. Newer
version of of template-haskell seem to be fully compatible with
freer-simple. That is, tests still pass and I haven't noticed any
issues in my own project (which use freer-simple).

Fixes lexi-lambda#40
@jjba23
Copy link

jjba23 commented Dec 26, 2023

I'd be extremely happy to see this one merged, otherwise I will soon feel forced to fork this beautiful project and maintain a more active version of code I don't have the mental capacity to fully comprehend.
Please @lexi-lambda take a look, or other maintainers ?
I am now forced to do extremely hacky stuff since I also use haskell.nix, and rebuild GHC several times

@nmeum nmeum changed the title Widen template-haskell version constraint to allow version 2.19 Widen template-haskell version constraint to allow version <2.22 May 16, 2024
@nmeum nmeum mentioned this pull request May 16, 2024
Closed
@nmeum
Copy link
Author

nmeum commented May 16, 2024

I updated this to allow template-haskell <2.22. This allows using freer-simple with GHC >=9.4. I have tested this extensively with GHC 9.8.2 in my own project (LibRISCV) which uses frere-simple with GHC 9.8.

I also requested a relaxation of the constraint via hackage-trustees here: haskell-infra/hackage-trustees#399

@nmeum
Copy link
Author

nmeum commented May 18, 2024

The constraint has been updated by the hackage-trustees so freer-simple now works again with GHC >= 9.4 && GHC <= 9.8.

@georgefst georgefst mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for template-haskell 2.19?
2 participants
@nmeum @jjba23