Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors thrown if certificates are missing and empty token is returned #1257

Open
crtl opened this issue Nov 28, 2024 · 1 comment
Open

Comments

@crtl
Copy link

crtl commented Nov 28, 2024

First of all thanks for the bundle, it helped a lot. Now for the issue:

Currently when the certificates are not configured or cannot be found the authentication endpoint just returns an empty string for the access token but the response is still successful (200)

It would be helpful to have at least an Internal Server Error response and some message logged to debug log.

composer.json dependencies

"require": {
        "php": "^8.3",
        "ext-ctype": "*",
        "ext-iconv": "*",
        "ext-openssl": "*",
        "crtl/request-dto-resolver-bundle": "^0.0.3",
        "doctrine/dbal": "^3",
        "doctrine/doctrine-bundle": "^2.13",
        "doctrine/doctrine-migrations-bundle": "^3.3",
        "doctrine/orm": "^3.3",
        "gedmo/doctrine-extensions": "^3.17",
        "gesdinet/jwt-refresh-token-bundle": "^1.3",
        "hidehalo/nanoid-php": "^2.0",
        "lexik/jwt-authentication-bundle": "^3.1",
        "nelmio/api-doc-bundle": "^4.33",
        "nelmio/cors-bundle": "^2.5",
        "pentatrion/vite-bundle": "^7.0",
        "phpdocumentor/reflection-docblock": "^5.6",
        "phpstan/phpdoc-parser": "^2.0",
        "stof/doctrine-extensions-bundle": "^1.12",
        "symfony/asset": "7.1.*",
        "symfony/console": "7.1.*",
        "symfony/dotenv": "7.1.*",
        "symfony/flex": "^2",
        "symfony/framework-bundle": "7.1.*",
        "symfony/mailer": "7.1.*",
        "symfony/monolog-bundle": "^3.10",
        "symfony/property-access": "7.1.*",
        "symfony/property-info": "7.1.*",
        "symfony/runtime": "7.1.*",
        "symfony/security-bundle": "7.1.*",
        "symfony/serializer": "7.1.*",
        "symfony/translation": "7.1.*",
        "symfony/twig-bundle": "7.1.*",
        "symfony/yaml": "7.1.*"
    },
"require-dev": {
        "doctrine/doctrine-fixtures-bundle": "^3.6",
        "liip/test-fixtures-bundle": "^3.1",
        "phpunit/phpunit": "^9.5",
        "symfony/browser-kit": "7.1.*",
        "symfony/css-selector": "7.1.*",
        "symfony/maker-bundle": "^1.61",
        "symfony/phpunit-bridge": "^7.1"
    }
@chalasr
Copy link
Collaborator

chalasr commented Jan 6, 2025

Thanks, fixed in #1267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants