Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lfc is broken on master and in our release artifacts #928

Closed
cmnrd opened this issue Feb 2, 2022 · 4 comments
Closed

lfc is broken on master and in our release artifacts #928

cmnrd opened this issue Feb 2, 2022 · 4 comments
Labels
bug Something isn't working build system lfc
Milestone

Comments

@cmnrd
Copy link
Collaborator

cmnrd commented Feb 2, 2022

lfc fails for the C++, Rust, and TypeScript targets, because it cannot load the Kotlin classes. I am clueless on what might be causing this, but something in the build setup must have changed recently. For this reason, the lfc 0.1.0-beta release artifacts to not work currently.

I also wonder why none of our tests revealed this problem.

@cmnrd cmnrd added the bug Something isn't working label Feb 2, 2022
@cmnrd cmnrd added this to the 0.1.0-beta milestone Feb 2, 2022
@petervdonovan
Copy link
Collaborator

I think this problem actually did appear in CI in the release branch, and it seemed to be a problem with Gradle's incremental build feature. Our "solution" was to use ./gradlew clean.

@housengw
Copy link
Contributor

housengw commented Feb 3, 2022

maybe we could add try ./gradlew clean in the error message as a pointer...

@lhstrh
Copy link
Member

lhstrh commented Feb 3, 2022

Confirming that the problem was how the artifacts were built (without clean). There is nothing actionable w.r.t. the code. I will create a separate issue to address apparent deficiency in our Gradle configuration.

@lhstrh lhstrh closed this as completed Feb 3, 2022
@lhstrh
Copy link
Member

lhstrh commented Feb 3, 2022

maybe we could add try ./gradlew clean in the error message as a pointer...

I think we should just fix the build configuration (as per #930). While the suggested error message might be useful for us, it won't be useful for third-party users (who don't build from source).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build system lfc
Projects
None yet
Development

No branches or pull requests

4 participants