Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification localization arguments fail on iOS due to strings files using %s instead of %@ #20

Closed
spstratis opened this issue Jan 10, 2018 · 5 comments

Comments

@spstratis
Copy link

spstratis commented Jan 10, 2018

When sending a localization key with localization arguments from APNS the localized arguments fail to display in the notification. This is due to the localizable strings file using %s instead %@ for formatting.

If I open up the Project in Xcode, and replace the format tokens with %@, build and run, everything works fine. Is there a known work around for this?

Unfortunately, putting the correct token in the JSON files would cause issues in Android one everything builds.

@lfabreges
Copy link
Collaborator

What is the error encountered when building Android ?

@spstratis
Copy link
Author

If you use the %@ as a formatting token in Android it causes the application to crash when a push notification is received.

The error message is:
java.util.unknownFormatConversionException: Conversion = '@'

@lfabreges
Copy link
Collaborator

Thanks, I'll look into it

@lfabreges
Copy link
Collaborator

I just published v2.2.0, let me know if it works

@spstratis
Copy link
Author

Looks like it's working great so far, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants