Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom domain names on the es endpoint #29

Closed
Konig-Corey opened this issue Dec 27, 2020 · 4 comments · Fixed by #35
Closed

Add support for custom domain names on the es endpoint #29

Konig-Corey opened this issue Dec 27, 2020 · 4 comments · Fixed by #35
Labels
enhancement New feature or request

Comments

@Konig-Corey
Copy link

Looks like aws supports custom domain names now, would love to add that support.

AWS Post about support
https://aws.amazon.com/about-aws/whats-new/2020/11/amazon-elasticsearch-service-now-supports-defining-a-custom-name-for-your-domain-endpoint/

@lgallard
Copy link
Owner

lgallard commented Jan 8, 2021

@Konig-Corey there're a couple of tickets currently open regarding this new feature:

As soon as it's available in the AWS provider I can include it in the module.

@dmytro-dorofeiev
Copy link

Hi, it seems this feature is already supported by aws provider. Could you please update the module?

@lgallard
Copy link
Owner

@dmytro-dorofeiev I'll take a look at the resource and make the needed changes that applies.

@lgallard
Copy link
Owner

@dmytro-dorofeiev @Konig-Corey this feature was included in the lasted release. Just include a block as follows:

  domain_endpoint_options = {
    enforce_https                   = true
    custom_endpoint_enabled         = true
    custom_endpoint                 = "lgallardo.com"
    custom_endpoint_certificate_arn = "arn:aws:acm:us-east-1:123456789101:certificate/abcd1234-ef11-abcd-1234-abcd1234efef"
  }

I updated the advanced_security_options_* in the examples folder as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants