Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next MSnbase dev call - 20190405 #454

Closed
lgatto opened this issue Apr 2, 2019 · 4 comments
Closed

Next MSnbase dev call - 20190405 #454

lgatto opened this issue Apr 2, 2019 · 4 comments

Comments

@lgatto
Copy link
Owner

lgatto commented Apr 2, 2019

We'll have our next call on Friday 5 April 2019 at 8h45. On the agenda so far:

Current affairs

  • MSnExperiment and assays.

Misc news

  • Jo to report from the metabolomics R hackathon

Possible new developments

Anyone, and in particular @sgibb and @jorainer, feel free to add agenda items to this issue.

@jorainer
Copy link
Collaborator

jorainer commented Apr 3, 2019

some notes re spectra annotation from the metaRbolomics hackathon:
https://docs.google.com/document/d/1zTTctc-M4jeqR2TCde27ytOP-YUxmPg53eW9bbphGws/edit#

@meowcat
Copy link

meowcat commented Apr 4, 2019

FYI, now in the works for the active use of the proposed "metadata" slot, by me, @Treutler and @michaelwitting: http://github.com/meowcat/MSnio. Potentially some of it could be merged into MSnbase at some point, if there is sufficient interest and agreement.

@meowcat
Copy link

meowcat commented Apr 4, 2019

Also FYI, if the peaksAnnotation slot is adopted, RMassBank will have a big use case and a lot less replicated infrastructure.

@lgatto
Copy link
Owner Author

lgatto commented Apr 5, 2019

Minutes from today's call:

Report from the metabolomics R hackathon - It was fun.

  • Genuine interest in MSnbase, resulting from the influence of MS2 in metabolomics and MS2 spectra databases

Spectra annotation

Requestion for 2 slots fields to Spectrum

  • metadata: list() with names of fields of schema and values
  • peakAnnotations: DataFrame() with peak annotations, also needs index to peaks

While the fields are valuable are fit with other needs, there are some serious flaws in the design. More details and further discussion in #456.

Spectra without MS level (see #452)

Not MS data, so leaving this for now.

MS schema

  • Compatibility between different MS2 databases
  • MS schema R package (see MSnio), possibly rename to msschemer
  • CompoundDB backend is under development, will be a good use case for other spectral libraries, make use of MSnio/msschemer for re-use across dbs.

Spectra

Externalise the new Spectra infrastructure in its own package to (1) ease up development and (2) possibly compartmentalise different parts of MSnbase for easier re-use by other packages (such as metabolomics spectral libraries).

This followed also from the discussion whether we still need the Spectum object? And indeed, that class is there (1) for historical reasons and (2) as a means to have an in memory implementation for spectra. But, in the medium term, data and metadata for MS spectra will be implemented through backends (in Spectra), where both spectra data (i.e. intensities and M/Z values) and metadata (all the rest) can be either in memory or on disk.

@lgatto lgatto closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants